Define the per-thread error detail once and release from the same CI run
This commit is contained in:
1 parent
6f6b5db6c2
commit
7ee1131c6f
5 files changed
+68
-97
No files matched your search
@@ -0,0 +1,11 @@
|
||||
#include "foundation/status.h"
|
||||
|
||||
namespace joc {
|
||||
|
||||
// The single definition of the per-thread detail string. It cannot live in the
|
||||
// header: a thread_local with dynamic initialisation that is included by several
|
||||
// translation units makes each of them emit its own TLS initialisation routine,
|
||||
// and ld64 rejects those as duplicate symbols (GNU ld and MSVC fold them).
|
||||
thread_local std::string last_error_detail;
|
||||
|
||||
} // namespace joc
|
||||
@@ -36,8 +36,10 @@ private:
|
||||
// Structured detail of the most recent failing call, as returned by
|
||||
// joc_last_error_detail(). It is one instance per thread across the whole
|
||||
// library, so every C entry point -- the task API and the streaming API alike --
|
||||
// reports through the same string.
|
||||
inline thread_local std::string last_error_detail;
|
||||
// reports through the same string. Defined in status.cpp: a thread_local with
|
||||
// dynamic initialisation defined in a header emits a TLS initialisation routine
|
||||
// in every including unit, and ld64 rejects those duplicates.
|
||||
extern thread_local std::string last_error_detail;
|
||||
|
||||
inline void record_error_detail(const Status& status) {
|
||||
if (status.ok()) {
|
||||
|
||||
Reference in new issue
Block a user